Give code is very easy to understand

But there is some error in this code that why code is not running properly

please give correct code which runs properly